fix: add encoding="utf-8" to state_store.py read_text/write_text calls - #114
Open
olong75 wants to merge 1 commit into
Open
fix: add encoding="utf-8" to state_store.py read_text/write_text calls#114olong75 wants to merge 1 commit into
olong75 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FarosStateStorepersists run records, events, artifacts and memory withPath.read_text()/Path.write_text()— six call sites, none of which passencoding="utf-8". Both methods fall back tolocale.getpreferredencoding(), which is not UTF-8 on Windows cp1252 systems or minimal containers running the C/POSIX locale.FAROS run data routinely contains non-ASCII content (Chinese paper topics, Unicode agent outputs), so on those hosts
create_run/save_memoryraiseUnicodeEncodeError, and reading a run back raisesUnicodeDecodeError.Changes:
encoding="utf-8"on all fiveread_text()call sites (list_runs,get_run,list_events,list_artifacts,get_memory)encoding="utf-8"on the singlewrite_text()call in_save_jsonVerified with
backend/tests/test_pr_b21_state_store_encoding.py: round-trips a run with a Chinese topic throughcreate_run→get_run/list_runs, and non-ASCII memory / events / artifacts through their save + list paths. All 3 tests pass.